Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot find module '@storybook/addon-svelte-csf' after update. #117

Closed
olafurw opened this issue Aug 1, 2023 · 8 comments
Closed
Labels
duplicate This issue or pull request already exists

Comments

@olafurw
Copy link

olafurw commented Aug 1, 2023

Describe the bug

After I update to the new 3.0.5 from the 3.0.3 version of @storybook/addon-svelte-csf I get this error from svelte-check

Error: Cannot find module '@storybook/addon-svelte-csf' or its corresponding type declarations. (ts)
<script lang="ts">
    import { Meta, Story } from '@storybook/addon-svelte-csf';

The package is there, it's installed. I tried reinstalling all of the packages but the error is still there. I'm not sure if this is a svelte-check error or something that's missing from the @storybook/addon-svelte-csf package.

Steps to reproduce the behavior

Repo: https://github.com/olafurw/addon-svelte-csf-import-bug

Environment

Node version: v18.16.0
npm version: v9.7.2
Operating System: linux 6.4.6-200.fc38.x86_64

@olafurw olafurw added the bug Something isn't working label Aug 1, 2023
@hobbes7878
Copy link
Collaborator

Should be fixed in #115

@hobbes7878 hobbes7878 added duplicate This issue or pull request already exists and removed bug Something isn't working labels Aug 1, 2023
@olafurw
Copy link
Author

olafurw commented Aug 1, 2023

I updated the repo branch to use the 3.0.6 and it's still failing. Also checked on my main project's branch, same.

Here's the runner with the error. https://github.com/olafurw/addon-svelte-csf-import-bug/actions/runs/5725774944/job/15514917402

@hobbes7878
Copy link
Collaborator

OK, gonna look more closely at what's going on, but closing this issue in favour of one nipped in before you: #116

@olafurw
Copy link
Author

olafurw commented Aug 1, 2023

Closing the one that has a github repo that reproduces the bug in favor one that just says there's a bug? Odd. Hope you fix it soon.

@hobbes7878
Copy link
Collaborator

Sorry, mate. First come/first served world... Check the proposed update to your tsconfig in that linked issue to see if that fixes it for ya.

@olafurw
Copy link
Author

olafurw commented Aug 1, 2023

First come/first served world

By definition then people that spend time to create a reproduction will be closed, so why would someone spend time to help you narrow down why a bug is occurring when it's just going to be closed in favor of someone that posted the error message?

I know I'm not going to in the future, sorry.

@JReinhold
Copy link
Collaborator

Thanks for your reproduction and bug report @olafurw . I think what @hobbes7878 was referring to, was that the conversation at #116 has more details that are valuable to fixing the issue.

I'll merge over your report to that issue, so we also have a reproduction.

@olafurw
Copy link
Author

olafurw commented Aug 1, 2023

No there wasn't more details. At the time when this issue was closed the latest comment was "Hmm, it still fails with 3.0.6"

I'm not going to keep commenting on this issue. I just think it's an odd choice to close an issue like this in favor of an issue with less detail when it's the first one. That's all, I'm not annoyed at all, it just came across as antithetical to what people usually want out of github bug reports.

I just hope the bug is fixed, that's all that matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants