chore(core): improve ruleset typings #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbemac
approved these changes
Apr 26, 2022
Comment on lines
+116
to
+121
| // eslint-disable-next-line @typescript-eslint/ban-types | ||
| export type Stringifable<T> = T extends object | ||
| ? { | ||
| [P in keyof T]: Stringifable<T[P]> | { toJSON?(): Stringifable<T[P]> }; | ||
| } | ||
| : T; |
Comment on lines
-4
to
+6
| "composite": true, | ||
| "compilerOptions": { | ||
| "composite": true | ||
| }, |
There was a problem hiding this comment.
Yeah, luckily newer TS caught this
Comment on lines
-43
to
+47
| "@stoplight/types": "12.3.0", | ||
| "@stoplight/types": "13.0.0", |
There was a problem hiding this comment.
Plans to bump to 13 in the other spectral packages?
There was a problem hiding this comment.
Yeah, I intend to do it
|
🎉 This PR is included in version @stoplight/spectral-core-v1.12.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract typing-related changes from #2026
Checklist
Does this PR introduce a breaking change?