Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): add unused components server rule #2097

Merged
merged 1 commit into from Mar 21, 2022

Conversation

jonaslagoni
Copy link
Collaborator

Partly solves #1103

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@jonaslagoni jonaslagoni requested review from smoya and a team as code owners March 17, 2022 21:25
@P0lip P0lip changed the title feat(functions): add unused components server rule feat(rulesets): add unused components server rule Mar 17, 2022
@P0lip
Copy link
Contributor

P0lip commented Mar 17, 2022

@jonaslagoni assuming you've received an invite and accepted it (which seems like you do according to what GH settings page tells me), perhaps create a branch in the Spectral repo itself?
You're welcome to create branches directly in the repo.
This should help with CI checks and our CircleCI setup doesn't like forks particularly much.

@jonaslagoni
Copy link
Collaborator Author

jonaslagoni commented Mar 17, 2022

You're welcome to create branches directly in the repo.
This should help with CI checks and our CircleCI setup doesn't like forks particularly much.

Haha, alright, I'll try to remember. It's just the standard we apply under AsyncAPI and the one that creates less clutter in upstream 😄

I was wondering why the jobs was not picked up by the CI 😅

@P0lip
Copy link
Contributor

P0lip commented Mar 17, 2022

Haha, alright, I'll try to remember. It's just the standard we apply under AsyncAPI and the one that creates less clutter in upstream 😄

Well, you can use the fork if that's how you approach it. I just wanted to let you know you can create branches here too, but it's not compulsory by any means, so you can continue to use the fork if that's how you do things.

I was wondering why the jobs was not picked up by the CI 😅

It should work just fine and it usually does, but for some reason, it got stuck this time around.
If that continues to happen, I'll spend some time investigating that.
I know we had a similar issue in https://github.com/stoplightio/prism for certain contributors, so it's not an isolated case.

Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like I'll need to merge this one cause of the CI.
LMK when you're good with the change, and I'll do it.
it's 👌 from my side

@jonaslagoni
Copy link
Collaborator Author

It seems like I'll need to merge this one cause of the CI.
LMK when you're good with the change, and I'll do it.
it's 👌 from my side

Fine by me yea 👍

@P0lip P0lip merged commit 71b312e into stoplightio:develop Mar 21, 2022
stoplight-spectral-bot pushed a commit that referenced this pull request Mar 24, 2022
# [@stoplight/spectral-rulesets-v1.7.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.6.0...@stoplight/spectral-rulesets-v1.7.0) (2022-03-24)

### Features

* **rulesets:** add unused components server rule ([#2097](#2097)) ([71b312e](71b312e))
@stoplight-spectral-bot
Copy link
Collaborator

🎉 This PR is included in version @stoplight/spectral-rulesets-v1.7.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni deleted the asyncapi-ruleset-improve branch March 24, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants