fix(functions): reset RegExp.lastIndex to zero when using cached RegExp objects #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
changed the title
P0lip
force-pushed
the
fix/pattern-lastIndex
branch
from
a41c6d3
to
66ab4fc
Compare
|
I pushed a new commit so that CI starts. It got stuck for some reason. |
stoplight-bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# [@stoplight/spectral-functions-v1.6.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-functions-v1.6.0...@stoplight/spectral-functions-v1.6.1) (2022-03-08) ### Bug Fixes * **functions:** reset RegExp.lastIndex to zero when using cached RegExp objects ([#2079](#2079)) ([4839527](4839527))
|
🎉 This PR is included in version @stoplight/spectral-functions-v1.6.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that when
gmarker is used the Spectral becomes non-deterministic due to RegExp cache inpatternfunction. So, in our case, validator returns different results on every second run (please see added tests).More details on RegExp.lastIndex:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/lastIndex
https://stackoverflow.com/a/13587801/280989
Quick example:
Checklist
Does this PR introduce a breaking change?