fix(ruleset-bundler): never externalize builtins #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
commented
Jun 3, 2022
| @@ -97,4 +98,50 @@ var spectral = { | |||
|
|
|||
| export { spectral as default };`); | |||
| }); | |||
|
|
|||
| it('given node target, should support commonjs for remote ruleset with builtin modules', async () => { | |||
4 tasks
mnaumanali94
approved these changes
Aug 3, 2022
stoplight-bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
# [@stoplight/spectral-ruleset-bundler-v1.3.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-bundler-v1.3.0...@stoplight/spectral-ruleset-bundler-v1.3.1) (2022-08-03) ### Bug Fixes * **ruleset-bundler:** never externalize builtins ([#2174](#2174)) ([fb1bbe6](fb1bbe6))
|
🎉 This PR is included in version @stoplight/spectral-ruleset-bundler-v1.3.1 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 2nd case in #2107
Checklist
Does this PR introduce a breaking change?
Additional context
This is somewhat similar to #2109 with that difference we alter the default resolution only if the builtins plugin is registered. Otherwise, externalization is not modified.