Did they way custom function load change from 5.9.2 to 6.1.0

[DFog14]

Heyoh,

We're trying to move our pipeline from Spectral v5.9.2 over to v6.1.0, but it seems our custom functions no longer load on v6.1.0 despite being error free on v5.9.2.
Specifically what is happening is that the first rule that makes reference to one of our functions is Error-ing out with the following:
Error at #/rules/path-elements-should-not-contain-textual-references/then: must have required property 'function'

Our "then: section for that particular rule is unchanged from v5 to v6 and looks like the following:

path-elements-should-not-contain-textual-references:
  description: path elements should not contain textual references
  given: $.paths
  severity: warn
  recommended: true
  then:
    function: "pathElements"
    functionOptions:
      notInclude: "text"

Thank you in advance

[P0lip]

The example you have should be fine. Do you have pathElements listed among functions?

[P0lip]

Submitting the whole ruleset is a bit of an ask, as it spans about 50+ separate files in several nest directories. I'll see about getting together a smaller example this week.

Ah, I see. Hold on then - I can hand you over a version with more verbose logging if that's possible.
Would that work?

[DFog14]

I stripped down our rule set to a more streamlined example to demonstrate the issue. Attached is a zip.
example.zip

If there's a way to enable more verbose logging during the rule set load, I'd be very appreciative if you could share that.

[P0lip]

Hey!
You need to add the following bit to sww-rules.yml

functionsDir: "./funcs"
functions:
  - pathElements

LMK if that worked.

You may see Cannot read property 'notInclude' of null when you run it because it seems like you don't pass options in here

  oas3-path-elements-should-not-contain-sww-references:
    description: path elements should not contain sww references
    given: $.paths
    severity: warn
    recommended: true
    then:
      function: "pathElements"

You should add some to make the error go away.

Hopefully that helps!

[DFog14]

Whoops, looks like I remove the functionOptions property before zipping those docs, that was my mistake.

I've tried adding the functionsDir and functions properties to the individual rule files, as you've recommended, and that now results in a slightly different error, "must NOT have additional properties".
I was under the impression that importing the functions in the main ruleset file or in .spectral.yml would allow them to become accessible in all the other files that are feeding into it.

[P0lip]

I've tried adding the functionsDir and functions properties to the individual rule files, as you've recommended, and that now results in a slightly different error, "must NOT have additional properties".

can you post the ruleset you ended up with?
I only made 2 changes in your initial ruleset to make it work, so perhaps you've changed a bit too much.

I was under the impression that importing the functions in the main ruleset file or in .spectral.yml would allow them to become accessible in all the other files that are feeding into it.

That used to be the case earlier in v5, but right now each fn has to be explicitly defined.