Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the /dist directory in the release instead of building the action in docker every time it runs #651

Open
bobergj opened this issue Jan 12, 2023 · 1 comment

Comments

@bobergj
Copy link

bobergj commented Jan 12, 2023

Context

Every time the actions runs there's a docker build step:

Build stoplightio/spectral-action@latest time: 1m 12s

That takes > 1 minute on the github ubuntu-latest (currently Ubuntu 22.04.1 LTS) image.
The actual validation of our openapi spec takes just under a second.

Current Behavior

The action is setup as a docker container action that builds the action every time it is executed.

Expected Behavior

Assumptions

  • All dependencies are pure typescript/javascript that can be precompiled and run on the github actions node.js version - there are no runtime dependencies that require executing in a docker container.
    • From a glance at the dependencies in the package.json, this seems to be true.
@jamietanna
Copy link

Relates to #452 - I may have a look at seeing if I can get a PR raised for this 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants