Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the Spectrial action shows warnings but still passes #626

Open
MarshallAsch opened this issue Jan 31, 2022 · 3 comments
Open

Running the Spectrial action shows warnings but still passes #626

MarshallAsch opened this issue Jan 31, 2022 · 3 comments

Comments

@MarshallAsch
Copy link

User story.

As a Developer I can do have warnings be reported as errors, so that the pipeline will fail so I know to fix them.

Is your feature request related to a problem?

Github actions only support a success and failure state, however spectral has support for warnings that get ignored.
Having an option to to have the warnings be reported as failures could be beneficial to cause the pipeline to fail to draw attention to the potential issue.

Describe the solution you'd like

The option to return an error status from an action when any warnings are present.

Additional context

Sample of the warnings being applied but the pipeline showing as passing
image

PR Check not showing the presents of any warnings
image

@Shmuppel
Copy link

same as #183 , and I definitely agree, it's a huge bummer that this isn't implemented

@ajrice6713
Copy link

You can resolve this by writing a custom ruleset to throw failures instead of warnings for specific things (like missing fields)

I think it was a desired behavior to pass on warnings and fail on errors - IMO that makes sense to me

@aharpervc
Copy link

Is it possible to have warnings show up as code comments rather than in the action log?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants