Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Consider migrating to @apidevtools/json-schema-ref-parser #2278

Open
daniel-white opened this issue May 4, 2023 · 0 comments
Open

Comments

@daniel-white
Copy link
Member

daniel-white commented May 4, 2023

  • @stoplightio/json-schema-ref-parser has a lot of tech debt: broken tests, no CD release, written in javascript
  • @P0lip says we might be able to move over

there are a few key features that we must have in @apidevtools/json-schema-ref-parser in order to adopt it

  1. setting custom user agent for http resolver
  2. ensure basic auth is translated into an Authorization header from a url
  3. improved error message for unresolvable JSON pointer segments (Prism issue, PR)

There are likely other features that I'm not aware of that in our fork, we added.

What questions to answer:

  1. what changed in our fork that the upstream doesn't have?
  2. are any of those critical still?
  3. how much work would it take to build in any features we need to retain in the upstream repo?
@chohmann chohmann changed the title Consider migrating to @apidevtools/json-schema-ref-parser SPIKE: Consider migrating to @apidevtools/json-schema-ref-parser May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants