stm32f2: document all ADC fields (same ADC peripherals as stm32f4) #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Nov 28, 2019
306: stm32f2: document all ADC fields (same ADC peripherals as stm32f4) r=adamgreig a=aurelj
307: complete stm32f0 ADC documentation r=adamgreig a=aurelj
309: Fix access of FLASH_SR.EOP in STM32L0 r=adamgreig a=hannobraun
I need some help getting this over the finish line. When I try to build the crates according to the instructions in README, I get this when executing `make svd2rust`:
```
python3 scripts/makedeps.py devices/stm32l0x1.yaml > .deps/stm32l0x1.d
python3 scripts/makedeps.py devices/stm32l0x3.yaml > .deps/stm32l0x3.d
python3 scripts/makedeps.py devices/stm32l0x2.yaml > .deps/stm32l0x2.d
python3 scripts/svdpatch.py devices/stm32l0x3.yaml
python3 scripts/svdpatch.py devices/stm32l0x1.yaml
python3 scripts/svdpatch.py devices/stm32l0x2.yaml
Traceback (most recent call last):
File "scripts/svdpatch.py", line 893, in <module>
main()
File "scripts/svdpatch.py", line 889, in main
svd.write(svdpath_out)
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 772, in write
serialize(write, self._root, qnames, namespaces,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
[Previous line repeated 2 more times]
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 935, in _serialize_xml
write(_escape_cdata(text))
TypeError: write() argument must be str, not collections.OrderedDict
make: *** [Makefile:39: svd/stm32l0x1.svd.patched] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
File "scripts/svdpatch.py", line 893, in <module>
main()
File "scripts/svdpatch.py", line 889, in main
svd.write(svdpath_out)
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 772, in write
serialize(write, self._root, qnames, namespaces,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
[Previous line repeated 2 more times]
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 935, in _serialize_xml
write(_escape_cdata(text))
TypeError: write() argument must be str, not collections.OrderedDict
make: *** [Makefile:39: svd/stm32l0x2.svd.patched] Error 1
Traceback (most recent call last):
File "scripts/svdpatch.py", line 893, in <module>
main()
File "scripts/svdpatch.py", line 889, in main
svd.write(svdpath_out)
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 772, in write
serialize(write, self._root, qnames, namespaces,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 937, in _serialize_xml
_serialize_xml(write, e, qnames, None,
[Previous line repeated 2 more times]
File "/usr/lib/python3.8/xml/etree/ElementTree.py", line 935, in _serialize_xml
write(_escape_cdata(text))
TypeError: write() argument must be str, not collections.OrderedDict
make: *** [Makefile:39: svd/stm32l0x3.svd.patched] Error 1
```
I have no idea what's happening. To the best of my knowledge, what I'm doing follows what I've seen in the other YAML files. Does someone know what I'm doing wrong here?
310: complete stm32f7 ADC documentation r=adamgreig a=aurelj
311: STM32F412: Add missing reset and enable registers for AHB3 r=adamgreig a=samcrow
The STM32F412 SVD is missing the registers RCC_AHB3RSTR and RCC_AHB3ENR. This commit adds them.
312: complete stm32h7 ADC documentation r=adamgreig a=aurelj
Co-authored-by: Aurelien Jacobs <aurel@gnuage.org>
Co-authored-by: Hanno Braun <hanno@braun-embedded.com>
Co-authored-by: Sam Crow <scrow@eng.ucsd.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.