fix: Return table for HGETALL from custom Lua scripts #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcostello-atlassian
changed the title
|
Hi @stipsan, this is my first time contributing to ioredis-mock (sidenote: thank you for maintaining this repo!) Is there anything left to do here before the PR is ready for review? Not sure if all CI steps passed or if something got stuck again. |
stipsan
approved these changes
Feb 23, 2022
|
Could you run |
This commit fixes a bug that causes HGETALL commands in Lua to fail with ioredis-mock. Redis returns an array reply for HGETALL. ioredis and ioredis-mock convert this response to a JS object. When using custom Lua scripts with ioredis, however, HGETALL returns and array-like table. With this change, HGETALL will also return an array-like table from Lua with ioredis-mock.
jcostello-atlassian
force-pushed
the
jcostello/fix-hgetall-lua
branch
from
1108cd3
to
a0368fc
Compare
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that causes HGETALL commands in Lua
to fail with ioredis-mock.
Redis returns an array reply for HGETALL. ioredis and ioredis-mock
convert this response to a JS object.
When using custom Lua scripts with ioredis, however, HGETALL returns
and array-like table. With this change, HGETALL will also return an
array-like table from Lua with ioredis-mock.