Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useTransition: Allow options override from html attributes #391

Open
adeys opened this issue Aug 2, 2023 · 3 comments
Open

useTransition: Allow options override from html attributes #391

adeys opened this issue Aug 2, 2023 · 3 comments

Comments

@adeys
Copy link

adeys commented Aug 2, 2023

Hi!
Actually the order of processing transition options is : options -> vue-type attribute -> alpinejs-type attribute and so it's impossible to override those options from html attributes.

What about going with the reverse priority using the useTransition options as fallback ? It would help defining default options in stimulus controller and allow overrides when needed from html. It's just a matter of getter priority and I may add a pull request for that.

Thanks

@adeys
Copy link
Author

adeys commented Dec 30, 2023

Hi @marcoroth

Still didn't get any feedback from this

@marcoroth
Copy link
Member

Hey @adeys, I sadly don't really have a strong opinion on the useTransition mixin. But please feel free to open a pull request if you think this improves the DX 🙏🏼

@adeys
Copy link
Author

adeys commented Dec 30, 2023

Thanks for your response, @marcoroth

Alright, I'll open a pull request then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants