Adds a new hook useBackgroundQueue #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
requested changes
Aug 6, 2022
There was a problem hiding this comment.
Hey @gremo, thanks for opening this!
This is already looking good! I think we should stick closer to the actual API name, because otherwise it might get kinda confusing. I would probably go with something like useRequestIdle() or useRequestIdleCallback().
I also left a few comments
|
|
||
| ```js | ||
| export default class extends ApplicationController { | ||
| static debounces = [ |
There was a problem hiding this comment.
This is to make it match the other one
Suggested change
| static debounces = [ | |
| static queue = [ |
but I'm also not sure if this name isn't a bit misleading. I'd vote for static idleCallbacks = []
| const defaultOptions = {} | ||
| const idleCallbackIds: number[] = [] | ||
|
|
||
| const ric = (fn: Function, maxWait?: number) => { |
There was a problem hiding this comment.
I think we should define window.requestIdleCallback if it's not defined already instead of wrapping it in a function and returning the function.
As it's outlined in the article you mentioned here.
Allow use of window.requestIdleCallback()` APIs easily in controllers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow use of window.requestIdleCallback()` APIs easily in controllers.
Resolves #209