Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useHotkeys: does not pass HotkeysEvent as argument to a handler. #201

Open
pySilver opened this issue May 10, 2022 · 4 comments
Open

useHotkeys: does not pass HotkeysEvent as argument to a handler. #201

pySilver opened this issue May 10, 2022 · 4 comments

Comments

@pySilver
Copy link

This is probably somehow related to #177

Setting up handler as this https://github.com/stimulus-use/stimulus-use/blob/main/src/use-hotkeys/use-hotkeys.ts#L46 causes that both arguments are KeyboardEvent while it's expected to be event: KeyboardEvent, handler: HotkeysEvent

@marcoroth marcoroth changed the title useHotkeys does not pass HotkeysEvent as argument to a handler. useHotkeys: does not pass HotkeysEvent as argument to a handler. Aug 6, 2022
@pySilver
Copy link
Author

Is that something to be changed any time soon?

@marcoroth
Copy link
Member

@pySilver do you have a hunch on how we could fix it? I'm not too familiar with the useHotkeys() yet

@pySilver
Copy link
Author

I thought it's a simple typo issue. Unfortunately I'm not familiar with useHotkeys too :(

@marcoroth
Copy link
Member

/cc @julianrubisch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants