Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useTransition & others: use the Values API? #129

Open
weaverryan opened this issue Mar 26, 2021 · 1 comment
Open

useTransition & others: use the Values API? #129

weaverryan opened this issue Mar 26, 2021 · 1 comment
Milestone

Comments

@weaverryan
Copy link
Contributor

Hi again!

I was trying to use the transition behavior's controller class directly today without writing any custom JavaScript. It is, of course, totally possible to do this :). Except that the options - e.g. hiddenClass or transitioned don't appear to have a way to set them via HTML attributes.

Could we add a way to set these via HTML attributes? And I would love for it to use the Values API. In the Symfony world (where I come from), we have a helper that makes setting values on a controller dead simple and clean.

And while it is currently possible to use data attributes to set things like enter-active, I think these should also be settable via the values API. We don't need to remove the current way of setting them as data attributes, just add the ability to use options :).

WDYT? Thanks!

@adrienpoly
Copy link
Contributor

Yes exactly, I have a WIP branch on exactly this topic. And this should be generalised to other mixins too.

@adrienpoly adrienpoly added this to the v1.0.0 milestone Apr 13, 2021
@marcoroth marcoroth changed the title useTransition & others: use the Values API? useTransition & others: use the Values API? Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants