semver-parser 0.10.0

[hone]

This combines the changes from mikrostew/semver@new-parser and the current master branch which makes it compatible with semver-parser 0.10.0 that hasn't quite been released. In order for the tests pass, it patches the semver-parser dependency to use GitHub.

Tracking Items Left:

• Tracking issue: NPM compatible version ranges #58
• fix test for Ensure = works with build metadata #88
• Merge support https://github.com/steveklabnik/semver/issues/88 steveklabnik/semver-parser#47
• Remove deprecation for VersionReq::any() as '*'
• VersionReq::parse_compat doc example
• Rename Compat::Node to Compat::Npm
• Release 0.10.0 of semver-parser crate
• Unpatch semver-parser in Cargo.toml

[steveklabnik]

This is amazing, and we should . Thanks so much again for doing this.

I have one quick question, since you've been in this code lately, but IMHO we should cut the semver-parser release, update this to use it, and cut a new semver release, probably over the next few days.

[steveklabnik]

So, I am actually not sure what the difference here is between "parses as *" and Any, that is, they should be the same?

[hone]

When I was comparing it on https://semver.npmjs.com/, they both resolve to the same set of versions. It's now not "deprecated". The question is if we care about making it deprecated (want to discourage people from using this)?

[steveklabnik]

Ah yes, the deprecation. Thanks :) It is probably fine to un-deprecate it, but I'd like to triple check against semver/semver#584 real quick to see if it's acceptable in that grammar....

[hone]

There's also some other TODOs we need to either clean up in this PR or another one before we ship a new version of both semver and semver-parser that @mikrowstew left behind.

[isaacs]

I think semver/semver#584 disallows it, but fwiw, node-semver parses it as * as well. If y'all move forward with doing it that way, we should update the spec to make that official.

[hone]

@isaacs that sounds good to me.

[mikrostew]

Wow, this is great! Thank you so much for seeing this through to the end ❤️

[steveklabnik]

@hone checking on this; did you want me to merge it now, or did you want to try to tackle the TODOs first? It wasn't clear to me :)

[hone]

@steveklabnik we can merge this in now and I can just do the other TODOs in a separate PR. We would just want to address them before releasing either crate.

[hone]

@mikrostew thanks for doing all the hard legwork here. :)

[hone]

@steveklabnik thoughts on renaming Compat::Node to Compat::NPM or Compat::Cargo to Compat::Rust?

[steveklabnik]

Yeah it should probably be Compat::Npm. Technically these are associated with the tools, not the languages.

[steveklabnik]

(Going to push a commit to un-patch semver-parser after this. Thanks for all the work, @hone <3)