Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagePlotly Storybook not working with Storybook 6.1.1 #133

Closed
alex-ketch opened this issue Nov 20, 2020 · 1 comment
Closed

ImagePlotly Storybook not working with Storybook 6.1.1 #133

alex-ketch opened this issue Nov 20, 2020 · 1 comment

Comments

@alex-ketch
Copy link
Contributor

In a recent dependencies update the ImagePlotly story stopped working.

After investigating turns out the script tag in the story gets omitted, and so the plot never renders.
The component itself still functions as before outside Storybook context, as well as when the data is passed in as prop on the WebComponent.

Will need to investigate changes in the Storybook and find/make a potential fix.
@alex-ketch
Copy link
Contributor Author

This was fixed by a PR to Storybook and deployed in #134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex-ketch