Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: consider removing peer drop based on application-provided predicates #4310

Open
marta-lokhova opened this issue May 9, 2024 · 0 comments · May be fixed by #4323
Open

overlay: consider removing peer drop based on application-provided predicates #4310

marta-lokhova opened this issue May 9, 2024 · 0 comments · May be fixed by #4323

Comments

@marta-lokhova
Copy link
Contributor

Consider undoing #4120. A couple of reasons:

  • It was originally added as a band-aid, and I'm not certain what the long-term vision for this functionality is. In the meantime, it just adds complexity and maintenance burden to the code with no clear value at this time.
  • It's unclear what a meaningful predicate would look like: for example, protocol-based predicates aren't super useful because of core state transitions.

Tagging as "discussion" to get a conversation started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant