Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: integration test, verify token contract xfer/burn methods #995

Closed
sreuland opened this issue Oct 3, 2023 · 2 comments · Fixed by #1071 · May be fixed by #1072
Closed

CLI: integration test, verify token contract xfer/burn methods #995

sreuland opened this issue Oct 3, 2023 · 2 comments · Fixed by #1071 · May be fixed by #1072

Comments

@sreuland
Copy link
Contributor

sreuland commented Oct 3, 2023

What problem does your feature solve?

no test coverage on token contract xfer/burn methods

What would you like to see?

two tests that create a token contract from classic asset, then. execute token contract xfer and burn methods from the two test infrastructures in the soroban-tools repo:

What alternatives are there?

@willemneal
Copy link
Member

@sreuland what is the benefit of both places? Both would invoke the CLI and make requests to the go server.

@sreuland
Copy link
Contributor Author

sreuland commented Nov 7, 2023

if the cli_test.go ultimately executes the same internal rust code path, then can adjust that requirement and remove the rust integration test and just focus on cli_test.go for coverage.

@2opremio 2opremio reopened this Nov 8, 2023
willemneal added a commit to AhaLabs/soroban-cli that referenced this issue Nov 8, 2023
willemneal added a commit to AhaLabs/soroban-cli that referenced this issue Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants