Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soroban settings upgrade failure is silent #547

Open
sisuresh opened this issue Jan 19, 2024 · 2 comments · May be fixed by #601
Open

Soroban settings upgrade failure is silent #547

sisuresh opened this issue Jan 19, 2024 · 2 comments · May be fixed by #601
Labels
bug

Comments

@sisuresh
Copy link
Contributor

quickstart/start

Line 509 in 974fb36

| stellar-core get-settings-upgrade-txs \
can fail due to bad values being set, but supervisor just catches the error and continues. We should fail on startup here.
@sisuresh sisuresh added the bug label Jan 19, 2024
@sisuresh sisuresh mentioned this issue Jan 19, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

@github-actions github-actions bot added the stale label Feb 19, 2024
@leighmcculloch leighmcculloch reopened this Apr 5, 2024
@sisuresh
Copy link
Contributor Author

We should prioritize this. The upgrade started failing silently after the v21 update.

This was referenced Apr 26, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop all services if core settings upgrade fails sisuresh/docker-stellar-core-horizon
3 participants
@leighmcculloch @sisuresh and others