Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset related fields missing from AccountDebited effect definition #778

Open
hanseartic opened this issue Apr 27, 2022 · 0 comments
Open
Labels

Comments

@hanseartic
Copy link

Describe the bug
Asset properties missing from AccountDebited interface

What version are you on?
10.0.1

To Reproduce
Check effects type definitions. AccountCredited inherits the fields in question from OfferAsset.

export interface AccountCredited extends BaseEffectRecord, OfferAsset {
    type_i: EffectType.account_credited;
    amount: string;
}
export interface AccountDebited extends BaseEffectRecord {
    type_i: EffectType.account_debited;
    amount: string;
}

Expected behavior
Handling AccountDebited objects should allow access to the currently not defined fields (i.e. asset_code, asset_issuer, asset_type).

Additional context
Maybe it would be cleaner to not import those fields from the OfferAsset interface.

@hanseartic hanseartic added the bug label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@hanseartic and others