Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types in OperationType #728

Open
aristidesstaffieri opened this issue Feb 5, 2024 · 0 comments
Open

Missing types in OperationType #728

aristidesstaffieri opened this issue Feb 5, 2024 · 0 comments
Labels

Comments

@aristidesstaffieri
Copy link

aristidesstaffieri commented Feb 5, 2024

Describe the bug
Missing revoke sponsorship types in OperationType

What version are you on?
@stellar/stellar-base@10.0.1

To Reproduce
Go to lab an build a "Revoke Sponsorship" op.
Select any of the options and fill out the fields.
Inspect the transaction and note that operation.type !== 'revokeSponsorship' but instead has a type specific to the type of revocation(revokeTrustlineSponsorship for example).

Expected behavior
The OperationType type would have op types matching the Operation type, which would allow clients downstream to switch over operation.type which is an Operation.BaseOperation<T extends OperationType = OperationType>.type.

Additional context
Here is where I step around this in a client - https://github.com/stellar/freighter/pull/1096/files#diff-e0ff0af943168c2545ebfe644635fa24c65c454685e591e279f3e410ab66fa23R644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant