Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with 9.0.0 Keypair #627

Open
silence48 opened this issue Jun 15, 2023 · 3 comments
Open

Issue with 9.0.0 Keypair #627

silence48 opened this issue Jun 15, 2023 · 3 comments
Labels
bug

Comments

@silence48
Copy link
Contributor

keypair.fromsecret throws on cloudflare workers now.

I am doing some tests, We may need to do some more thorough checks for isundefined and isstring, I will probably add some helpers in util and refactor those.
@silence48 silence48 added the bug label Jun 15, 2023
@silence48
Copy link
Contributor Author

strangely i can no longer replicate this bug.

@silence48 silence48 changed the title Issue with 9.0.0 Keypair likely caused from lodash removal. Issue with 9.0.0 Keypair Jun 27, 2023
@silence48
Copy link
Contributor Author

I did some further testing, when using the branch 'remove-lodash' the bug doesn't exist. I've been unable to track if the problem is with the 9.0.0 release or if it's something with my dapp. For now we are using 9.0.0-beta.3 til I figure it out.

@Shaptic
Copy link
Contributor

Shaptic commented Oct 2, 2023

@silence48 is this still true? 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shaptic @silence48