Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing XDR objects from a dependency #617

Open
mootz12 opened this issue Jun 1, 2023 · 3 comments
Open

Sharing XDR objects from a dependency #617

mootz12 opened this issue Jun 1, 2023 · 3 comments
Labels

Comments

@mootz12
Copy link

mootz12 commented Jun 1, 2023

Describe the bug
When attempting to create a package that manages building the complicated XDR objects required for Soroban, I am unable to use separate but identical versions of stellar-base to handle these XDR objects. The use case is the consumer (a dApp or node script, for example) likely already relies on soroban-client and/or stellar-sdk.

For more context see the discussion in discord here: https://discord.com/channels/897514728459468821/1113560546705428600

What version are you on?

"stellar-base": "9.0.0-soroban.3"

To Reproduce
Steps to reproduce the behavior:

  1. Go the MVE Repository and follow the reproduction steps https://github.com/mootz12/mve-xdr-dependency

Expected behavior
The XDR object created by the dependency is valid

Additional context
The current workarounds are to re-export xdr that the dependency uses, or to have the package return the xdr objects as strings and expect the consumer to build them from the string.

@mootz12 mootz12 added the bug label Jun 1, 2023
@silence48
Copy link
Contributor

can using yarn resolutions help?

@Shaptic
Copy link
Contributor

Shaptic commented Oct 9, 2023

@mootz12 is this still true?

@mootz12
Copy link
Author

mootz12 commented Oct 10, 2023

Yeah, I updated the stellar-base dependency to 10.0.0-beta.3 on the MVE repo above and was still observing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants