Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option in build to increment account sequence optionally #574

Open
aristidesstaffieri opened this issue Feb 9, 2023 · 1 comment
Open
Assignees

Comments

@aristidesstaffieri
Copy link

Is your feature request related to a problem? Please describe.
When using SorobanClient.Account and passing it a sequence number, it can be confusing to know if this sdk expects the current number or incremented number. I made this mistake of using the incremented number provided by the laboratory while the sdk also expects to do the increment itself. One suggestion in chat was to match what the Go SDK does and allow an optional increment to be a bit more clear.

Describe the solution you'd like
An option in tx.build to explicitly increment an account sequence number in order to match expected or matching behavior to the other tools in the ecosystem.

Describe alternatives you've considered
We could add extra error handling to check an account's sequence number when this happens and add detail or direction to let the library do the incrementing.

Additional context
Link to chat - https://stellarfoundation.slack.com/archives/C030Z9EHVQE/p1675981362546079

@aristidesstaffieri aristidesstaffieri self-assigned this Feb 9, 2023
@ire-and-curses
Copy link
Member

Approach in the Go SDK with optional arg: stellar/go#1259 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

5 participants