Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for a modern SDK #532

Closed
BenRacicot opened this issue May 28, 2022 · 2 comments · Fixed by #584
Closed

Update dependencies for a modern SDK #532

BenRacicot opened this issue May 28, 2022 · 2 comments · Fixed by #584

Comments

@BenRacicot
Copy link

BenRacicot commented May 28, 2022

After digging into the SDK and the API I've noticed several issues and some true roadblocks for front-end web applications.

  1. Webpack 5:
    The SDK currently uses Webpack 4.33.0. This is a roadblock for all modern apps and frameworks (WP 5 environments)
  2. TypeScript 4.5+:
    TypeScript 3.4.5 is outdated and an optimized TS developer experience is healthy, safer and easier for everyone.
  3. Fallbacks, updates or recommendations:
    Eventsource and Webpack 4 is a roadblock [732] in a Webpack 5 world. Itself and its deps must be polyfilled.
    This is a compounded issue because the SDK's version 1.0.7 (> 4 years old) would likely require polys that match this version.
  4. BigNumber: Just spent an hour debugging rt.times(...).greaterThan is not a function which was fixed by falling back to "bignumber.js": "7.2.1" from 9.0.2
@BenRacicot
Copy link
Author

I finally got Angular polly'd to get the SDK operational. I'm very surprised at how stale this technology is.
Perhaps @Shaptic would be willing to discuss this in depth? I'm doing something pretty cool at wallethack.com.

Really hope this issue gets the attention it needs from leads at SDF.

oliverdozsa added a commit to oliverdozsa/devote-app that referenced this issue Aug 27, 2022
@Shaptic Shaptic linked a pull request Apr 4, 2023 that will close this issue
3 tasks
@Shaptic
Copy link
Contributor

Shaptic commented May 16, 2023

I'm going to close this issue as closed in v9.0.0-beta. Please reopen (or, better yet, comment on #584) if there is more you'd like to see.

@Shaptic Shaptic closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants