Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manageBuyOffer inconsistent parameter naming #200

Open
MisterTicot opened this issue Jun 8, 2019 · 1 comment
Open

manageBuyOffer inconsistent parameter naming #200

MisterTicot opened this issue Jun 8, 2019 · 1 comment
Labels
bug Hacktoberfest suggested issues for Hacktoberfest

Comments

@MisterTicot
Copy link
Contributor

In js-stellar-base, manageBuyOffer amount parameter has been named buyAmount.

However, in the stellar.org guide it is referenced as amount. Horizon uses amount parameter as well when returning the operation record.

Hence, I assume js-stellar-base should use amount instead of buyAmount for a matter of consistency, which is also more consistent with manageSellOffer & passiveSellOffer amount parameters.

@MisterTicot MisterTicot added the bug label Jun 8, 2019
@MisterTicot
Copy link
Contributor Author

The sooner this one is dealt with, the better: the last thing we want is inconsistent naming to accumulate over time.

@abuiles abuiles added the Hacktoberfest suggested issues for Hacktoberfest label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hacktoberfest suggested issues for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants