Port to Typescript

[morleyzhi]

This is a more direct way to address #183, and to add type safety to the library.

TODOs (copied from js-stellar-sdk migration)

• Rename files from js to ts
• Fix errors from npx tsc
• Make sure prettier is running on src/
• Upgrade to Webpack 4, since ts-loader won't run on Webpack 1
• Make codebase pass tslint
• Make sure tslint is running on src/ on commit
• Update types
• Pass CI tests
• Bump versions
• Release the typescript branch as an alpha
• Fix or document backwards-incompatible type definitions
• Fix document generation
• Upgrade in-development projects to typescript build
• Once this has been up and used in production, merge into master
• How to handle XDR's auto-generated code? https://github.com/stellar/js-stellar-base/blob/master/src/generated/stellar-xdr_generated.js#L1

Files WIP

• src/account.ts @abuiles
• src/asset.ts @abuiles
• src/base58.ts
• src/browser.ts
• src/generated/stellar-xdr_generated.ts
• src/hashing.ts @Akuukis
• src/index.ts
• src/keypair.ts @Akuukis (revisit)
• src/memo.ts @abuiles
• src/network.ts @abuiles
• src/operation.ts
• src/operations/account_merge.ts @abuiles
• src/operations/allow_trust.ts @abuiles
• src/operations/bump_sequence.ts @abuiles
• src/operations/change_trust.ts @abuiles
• src/operations/create_account.ts @abuiles
• src/operations/create_passive_sell_offer.ts
• src/operations/index.ts
• src/operations/inflation.ts
• src/operations/manage_buy_offer.ts
• src/operations/manage_data.ts
• src/operations/manage_sell_offer.ts
• src/operations/path_payment.ts
• src/operations/payment.ts
• src/operations/set_options.ts
• src/signing.ts @abuiles
• src/strkey.ts @abuiles
• src/transaction.ts @Akuukis
• src/transaction_builder.ts
• src/util/checksum.ts @abuiles
• src/util/continued_fraction.ts @Akuukis
• src/vendor/bs58.ts @Akuukis

[abuiles]

@Akuukis @charlie-wasp I've kicked off gears for this, I'm pinging you since you both show interests on helping with this :).

I created a branch called typescript where we can start merging updates. The first PR was very basic, it added TS to package.json and rename all the file #216

Now we need to make npx tsc to actually work and setup the build/test pipeline. If you want to start updating files, I'll suggest you leave a comment here telling which files you are working on, so we don't overlap on each others work :). Also let's try to do small PRs so we can review and merge more easily.

Let's do this! 🚀

[Akuukis]

@abuiles Here's a batch of migrations:

• fix(typescript): hashing #240 Hashing, including fix for wider typings.
• fix(typescript): continued_fraction #241 Continued Fraction
• fix(typescript): bs58 #242 bs58
• fix(typescript): keypair #243 Keypair, including new error when neither secretKey or publicKey is provided
• fix(typescript): transaction #244 Transaction, doesn't compile yet due missing xdr types and many any
• fix(typescript): base58 #245 Base58, including a hacky typecast from number[] to Buffer-alike that needs investigation
• does src/browser.ts need anything at all? LGTM as it is.

[charlie-wasp]

@abuiles I believe, I'm pretty late for the party 😅 But it seems, that work is not over yet. How can I help here? Should I take some unchecked points from the top comment and work on them?

[abuiles]

@charlie-wasp hey! Better late than never -- we still got some work to do. I'm happy if you can help on this, we have a branch with the current changes - we can continue work off that branch.