New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed files no committed #233
Comments
The responsible line for adding files to the commit has not been updated in the last 15 months. However, Have to do some manual testing. |
I've added a test in dce7e85 to cover this scenario. To commit all files, it seems you have to add a pattern to explictly look for In your example it would be - name: Commit changed files
uses: stefanzweifel/git-auto-commit-action@v4
with:
commit_message: Apply phpstan-baseline changes
branch: ${{ github.head_ref }}
- file_pattern: '*.neon'
+ file_pattern: '*.neon **/*.neon' Could you give this a try? |
Thx for the investigation Should |
@staabm Yeah that seems to work too. Triggered a test run in a test repo with PHP files in the root and in a nested folder have been commited: stefanzweifel/git-auto-commit-action-demo-app@0e9ba3a |
ok cool, thank you. from my POV this issue can be closed |
Version of the Action
v4
Describe the bug
it seems the action does not commit all changed files (files in subfolders are left behind).
the action properly detects that the files contain changes, as can be seen in the github action log:
.. only
M phpstan-baseline.neon
is committed, but notM scripts/phpstan-baseline.neon
To Reproduce
workflow step:
Expected behavior
since the pattern is
*.neon
I would expect the action to commit all changed*neon
files, no matter in which directory they are containedScreenshots
n/a
Used Workflow
# Paste the Workflow you've used here
Additional context
I am pretty sure this worked in the past, and it seems to have regressed in a recent release?
The text was updated successfully, but these errors were encountered: