Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run git-auto-commit, linter and tests checks on pull requests #173

Merged

Conversation

webignition
Copy link
Contributor

Update the on-event definitions for the git-auto-commit, linter and tests workflows.

  • run workflows on all pull requests
    The relevant workflows run only on push events. Triggering these workflows on pull_request event ensures that checks will run when pull request are opened. This allows contributions from forks to have checks run.
  • restrict on-push events to only pushes into master
    Currently these workflows are triggered by push events to any branch. Since changes should only be introduced to master via pull requests, triggering these workflows on all push events seems unnecessary.

Summary:

  • workflow runs on pull requests ensure checks are run before code reaches master
  • workflow runs on pushes to master act as a backup to verify that the post-merge push to master didn't introduce any breakage

@stefanzweifel
Copy link
Owner

Thanks!
Linting currently fails, but that's not a big issue. I assume this is due to the fact, that the PR is coming from a fork and not having the right permissions.

For now, I've reverted the linter to only run on a push event. tests are imho much more important.

@stefanzweifel stefanzweifel merged commit 0426839 into stefanzweifel:master Sep 10, 2021
@webignition webignition deleted the run-checks-on-pull-request branch September 10, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants