Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail against colander 1.7.0 #107

Closed
risicle opened this issue Apr 21, 2019 · 2 comments
Closed

Tests fail against colander 1.7.0 #107

risicle opened this issue Apr 21, 2019 · 2 comments

Comments

@risicle
Copy link

risicle commented Apr 21, 2019

Only a single, quite subtle failure:

======================================================================
FAIL: test_dictify_with_null (tests.test_schema.TestsSQLAlchemySchemaNode)
Test SQLAlchemySchemaNode.dictify(obj) with null values
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/ColanderAlchemy-0.3.3/tests/test_schema.py", line 463, in test_dictify_with_null
    self.assertEqual(appstruct, newappstruct)
AssertionError: {'institution_id': None, 'sensor_id': 3, 'sensor_label': <colander.null>} != {'institution_id': <colander.null>, 'sensor_id': 3, 'sensor_label': <colander.nu [truncated]...
- {'institution_id': None, 'sensor_id': 3, 'sensor_label': <colander.null>}
+ {'institution_id': <colander.null>,
+  'sensor_id': 3,
+  'sensor_label': <colander.null>}

which is presumably caused by this Pylons/colander#204 (comment)

risicle added a commit to risicle/nixpkgs that referenced this issue Apr 25, 2019
ColanderAlchemy doesn't seem to have been updated for colander 1.7.0,
or at least its tests haven't been and we get a single, subtle test
failure around null handling which I don't feel comfortable skipping.
Issue filed upstream stefanofontanelli/ColanderAlchemy#107

users that really need this will have to feed in their own pinned
colander package.
dotlambda pushed a commit to NixOS/nixpkgs that referenced this issue Apr 26, 2019
…59975)

ColanderAlchemy doesn't seem to have been updated for colander 1.7.0,
or at least its tests haven't been and we get a single, subtle test
failure around null handling which I don't feel comfortable skipping.
Issue filed upstream stefanofontanelli/ColanderAlchemy#107

users that really need this will have to feed in their own pinned
colander package.
@tisdall
Copy link
Collaborator

tisdall commented Mar 3, 2020

I've fixed the tests so they now work with the latest version of colander. I didn't create a new release, though, as there's no functional changes. Do you need a new release for what you're doing so the test included with the package pass?

@tisdall
Copy link
Collaborator

tisdall commented Mar 3, 2020

The package doesn't actually include the tests, but I put out another release any way just to show that the project is still valid and running.

@tisdall tisdall closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants