Fix #110 - validate patch document during creation #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankoegl
requested changes
Nov 20, 2020
Comment on lines
+225
to
+227
| for op in self.patch: | ||
| self._get_operation(op) | ||
|
|
There was a problem hiding this comment.
Could you add a comment here? It's obvious what it does in the context of the pull request, but without that context it will not be so obvious anymore.
|
Merged, thanks :) |
|
I have just released v1.27 which inlcudes this PR. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR verifies that the operations are valid during patch creation. I also added tests for the structure of each operation type.