Fix issue not recognizing that, in JSON, 1 != 1.0 != True #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2020 10:50
…nders 2 values. This avoids flagging mismatches between classes which happen to be different but which are JSONified as the same thing.
stefankoegl
requested changes
Jan 28, 2020
| isinstance(dst, MutableMapping): | ||
| self._compare_dicts(_path_join(path, key), src, dst) | ||
|
|
||
| elif isinstance(src, MutableSequence) and \ | ||
| isinstance(dst, MutableSequence): | ||
| self._compare_lists(_path_join(path, key), src, dst) | ||
|
|
||
| elif json.dumps(src) == json.dumps(dst): |
There was a problem hiding this comment.
Could you please ask a comment to describe this comparison? It makes sense now in the context of this pull request, but it might be confusing if you look at it a year from now.
There was a problem hiding this comment.
Done, plus a note about how performance could later be improved.
stefankoegl
approved these changes
Jan 29, 2020
|
Thanks! I have just released v1.25 with this fix. |
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: