Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fish shell #89

Open
Radiergummi opened this issue Nov 24, 2019 · 2 comments
Open

Support for fish shell #89

Radiergummi opened this issue Nov 24, 2019 · 2 comments

Comments

@Radiergummi
Copy link

Radiergummi commented Nov 24, 2019

As it seems, you don't currently support auto-completion for the fish shell. Fish is a well-established shell by now, I think (are there any statistics on shell usage?), so it'd make sense to add support.

I've just stumbled across this problem, but I really like your approach and would like to contribute a PR if there is any interest in supporting fish. As far as I've seen, both bash and zsh are implemented as string variables in the HookFactory currently.
Would it make sense to outsource this into a more generic Hooks\${ shellName }Factory approach?

@stecman
Copy link
Owner

stecman commented Nov 24, 2019

Happy to have Fish support added 👍

CompletionCommand:: escapeForShell is probably in the wrong place responsibility-wise, so splitting out each supported shell into its own class sounds like a good direction.

@Radiergummi
Copy link
Author

awesome 👍
I'll see what I can come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants