New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename opt to oeth #19974
chore: rename opt to oeth #19974
Conversation
Jenkins BuildsClick to see older builds (12)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Not sure how to find all the possible usages of opt
, but I couldn't find any on your branch using a global search. So it should be okay I think 😄
81% of end-end tests have passed
Failed tests (8)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (42)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
cd7455b
to
0246b8c
Compare
Hi @OmarBasem ! Have found an issue. ISSUE 1: user can not scan receiver address on Send to screen Steps:
Actual result: "Oops" error occurs |
There is a |
@OmarBasem ok👍 , just let me know then! |
@OmarBasem - Can you help update this branch/PR with the latest changes in the status-go PR? There are migration changes in it. I did run some test locally on Simulator and it worked fine. It's good that we test it in real device. |
0246b8c
to
d35ef10
Compare
@smohamedjavid are you sure the multichain scan worked for you? It still did not work for me after I updated status-go here. Probably there is something in the validation I need to fix/update Update: fixed it. |
@mariia-skrypnyk fixed it! |
Hey @churik, letting you know that I am updating status-go version here from |
87% of end-end tests have passed
Failed tests (5)Click to expandClass TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
Hi @OmarBasem ! Thanks for your fix, it works on both platforms! |
ba3c3ce
to
3054f57
Compare
fixes: #19963
Summary
This PR updates the short-name for Optimism network from
opt
tooeth
across the codebase.QA: What needs to be tested?
Just a smoke test and check the areas where the networks short names are used