Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to view key-pair QR code from wallet settings #19946

Closed
Tracked by #19936
seanstrom opened this issue May 9, 2024 · 0 comments · Fixed by #20073
Closed
Tracked by #19936

Allow users to view key-pair QR code from wallet settings #19946

seanstrom opened this issue May 9, 2024 · 0 comments · Fixed by #20073
Assignees
@mohsen-ghafouri
Labels
E:Mobile Wallet Settings - Key Pairs and Accounts The epic for implementing the key-pairs and accounts settings for the mobile wallet settings. E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team
Milestone
2.30.0 Beta

Comments

@seanstrom
Copy link
Member

Feature Issue

User Story

As a user,
I want view the QR code of a key-pair while inside the wallet settings.

Description

Implement the action for displaying the QR code for a key-pair inside wallet settings.

Designs

Figma action menu flow: the Figma designs for the action menu

Figma QR code flow: the Figma designs for the QR code

Notes

  • Based on the designs here, the user should be required to authenticate before revealing a key-pair's QR code. The authentication step should happen after the user confirmed to see the QR code by "sliding to reveal".

Acceptance Criteria

Screen Description
Key-pair Actions Menu Users can choose to show the encrypted QR code of a key-pair with the actions menu.
Key-pair Reveal QR Code Users are asked to use the "slide to reveal" UI button to confirm that they want to view the QR code.
Key-pair Display QR Code Users are able to see the QR code for the key-pair.
@seanstrom seanstrom added E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team E:Mobile Wallet Settings - Key Pairs and Accounts The epic for implementing the key-pairs and accounts settings for the mobile wallet settings. labels May 9, 2024
@seanstrom seanstrom mentioned this issue May 9, 2024
Open
4 tasks
@mohsen-ghafouri mohsen-ghafouri self-assigned this May 10, 2024
@smohamedjavid smohamedjavid added this to the 2.30.0 Beta milestone May 16, 2024
mohsen-ghafouri added a commit that referenced this issue May 16, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
e856756
@mohsen-ghafouri mohsen-ghafouri mentioned this issue May 16, 2024
Merged
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
e4c967e
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
3e5d478
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: integrate generate key pair export connection
42c1216
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
42384b2
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: integrate generate key pair export connection
4b900ec
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: integrate generate key pair export connection
c60af0d
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
bf99913
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] feat: integrate generate key pair export connection
8e6d7ba
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] fix: reviewer feedbacks
b25216b
mohsen-ghafouri added a commit that referenced this issue May 17, 2024
@mohsen-ghafouri
[#19946] fix: reviewer feedbacks
2c6899d
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
ae5f32d
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] feat: integrate generate key pair export connection
23965dc
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] fix: reviewer feedbacks
d8efb87
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view
edcd1f0
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] feat: integrate generate key pair export connection
78dfbc8
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] fix: reviewer feedbacks
c59bebd
mohsen-ghafouri added a commit that referenced this issue May 20, 2024
@mohsen-ghafouri
[#19946] feat: add key pair QR code view (#20073)
389a730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
E:Mobile Wallet Settings - Key Pairs and Accounts The epic for implementing the key-pairs and accounts settings for the mobile wallet settings. E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

[#19946] feat: add key pair QR code view status-im/status-mobile
3 participants
@seanstrom @smohamedjavid @mohsen-ghafouri