Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Show a list of saved addresses and details #19727

Open
Tracked by #18568
shivekkhurana opened this issue Apr 19, 2024 · 1 comment · May be fixed by #19903
Open
Tracked by #18568

📜 Show a list of saved addresses and details #19727

shivekkhurana opened this issue Apr 19, 2024 · 1 comment · May be fixed by #19903
Labels
E:Mobile Wallet Save Address Page MVP all issues for the save address page of the wallet E:Mobile Wallet Settings All issues for the mobile wallet settings feature feature requests T:Mobile Wallet Settings Mobile Wallet Settings Team
Milestone

Comments

@shivekkhurana
Copy link
Contributor

shivekkhurana commented Apr 19, 2024

Feature Issue

User Stories

👀 As a user,
I want to see a list of all addresses I have saved

🔍 As a user,
I should be able to search for addresses by address, name and network

☝️ As a user,
I want to see the details related to the address
(Right now, its minimal, but eventually we'll see the activity related to the address)

Acceptance Criteria

Screen Description Acceptance Criteria
image List to show all saved addresses, grouped by first letter of the Name 1. There should be a header
2. The filter should work on address, name and network (link to ui of search)
3. Back button should take back to "Wallet Setttings" Screen
4. Clicking on an address should take you to the "Address details" screen
5. The "Plus" button is not supposed to work in this issue
image Address detail screen 1. Back should take you the list of all saved addresses
2. Send should initiate the send flow with this address already selected
3. The banner and button color should be the address color
4. Copy should copy address to clipboard
5. Pressing the menu (3 dots) should open the same menu as long press on address (in a separate PR)
image Filter where no address is found 1. If no address found, this illustration should be rendered

Notes

Figma flow: https://www.figma.com/file/hLFPHYnuM0pOzgiabtqQ6k/Descoped-Wallet-settings-for-Mobile?type=design&node-id=74-33979&mode=design&t=LyvXRKYbPnjuJbOl-4

@shivekkhurana shivekkhurana added feature feature requests E:Mobile Wallet Save Address Page MVP all issues for the save address page of the wallet labels Apr 19, 2024
@shivekkhurana shivekkhurana self-assigned this Apr 19, 2024
@shivekkhurana shivekkhurana removed their assignment Apr 26, 2024
@ibrkhalil ibrkhalil self-assigned this May 5, 2024
@ibrkhalil
Copy link
Contributor

After discussing this issue with @churik
We agreed that it's better to descope the searching feature of this issue for now.

@ibrkhalil ibrkhalil linked a pull request May 5, 2024 that will close this issue
@smohamedjavid smohamedjavid added this to the 2.30.0 Beta milestone May 21, 2024
@smohamedjavid smohamedjavid added E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Wallet Save Address Page MVP all issues for the save address page of the wallet E:Mobile Wallet Settings All issues for the mobile wallet settings feature feature requests T:Mobile Wallet Settings Mobile Wallet Settings Team
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants