Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to get in touch regarding a security concern #9232

Open
psmoros opened this issue Apr 24, 2024 · 8 comments
Open

How to get in touch regarding a security concern #9232

psmoros opened this issue Apr 24, 2024 · 8 comments

Comments

@psmoros
Copy link

psmoros commented Apr 24, 2024

Hello 馃憢

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@tvnnn) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 馃憤

(cc @huntr-helper)

@toolslive
Copy link

Hi, think I found an issue (might be the same as the potential issue above, or a different one). So can we move forward with this?

The alternative is just adding an issue with a tag security but I would like to give you a head start.

@bashtage
Copy link
Member

bashtage commented May 8, 2024

Is it the use of pickle?

@toolslive
Copy link

No.

@josef-pkt
Copy link
Member

josef-pkt commented May 20, 2024

Should we activate
https://docs.github.com/en/code-security/security-advisories/guidance-on-reporting-and-writing-information-about-vulnerabilities/privately-reporting-a-security-vulnerability

then maintainers would get notifications and it's private.

codeql does not show any security warnings, except jinja doc build which is build and not user code.
https://github.com/statsmodels/statsmodels/security/code-scanning

@toolslive
Copy link

the "privately-reporting-a-security-vulnerability" flow doesn't seem to work.
Alternatively I could just post a proof of concept exploit here. The maintainers had ample opportunity to react.

@bashtage
Copy link
Member

Just go ahead and post it.

@josef-pkt
Copy link
Member

or send a private email to me and bashtage

@josef-pkt
Copy link
Member

the "privately-reporting-a-security-vulnerability" flow doesn't seem to work.

we have not enabled it yet.
My question was whether we need or should enable it.

In general, statsmodels is intended for interactive use or automated use.
E.g. formula handling by patsy and formulaic use eval. It's the responsibility of the caller not to do anything unsafe.

In statsmodels itself, I think we are not doing anything that can cause security concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants