Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dev-deps fails #279

Closed
Zurina opened this issue Nov 17, 2019 · 4 comments
Closed

make dev-deps fails #279

Zurina opened this issue Nov 17, 2019 · 4 comments

Comments

@Zurina
Copy link

Zurina commented Nov 17, 2019

Go version: go1.13.1 linux/amd64

Describe the bug
The project relies on the dependency 99designs/gqlgen which relies on urfave/cli that currently has a bug in it. So when ''make dev-deps'' runs, it errors. Link to git issue: urfave/cli#925

To Reproduce
Steps to reproduce the behavior:

  1. git clone the project
  2. make sure you dont have any local versions of the go packages, "99designs/gqlgen" or "urfave/cli"
  3. run ''make dev-deps''

Expected Behavior
That it installs the required dependencies without error.

image

@hunterlong
Copy link
Member

hey @Zurina , which version of Golang are you on? I'm on version go1.13.1 darwin/amd64 and couldn't recreate this issue.

@Zurina
Copy link
Author

Zurina commented Nov 19, 2019

Hey @hunterlong, thanks for answering! I'm running the same Golang version as you. Did you also delete your existing local versions of 99designs/gqlgen & urfave/cli ( if you have them ) ?

It's being talked about here: urfave/cli#925

@coilysiren
Copy link

urfave/cli that currently has a bug in it

@Zurina @hunterlong hey both, the issue you've linked (urfave/cli#925) doesn't describe a bug, and I'm not currently tracking any active bugs.

The root cause of urfave/cli#925 was that people are using our package straight from master, and looking at your screenshot 👀 it looks like that's your problem too. Go through to links in this issue urfave/cli#921 for some guidance on how to update from v1 to v2.

@hunterlong
Copy link
Member

Statping uses go modules now. If you run go get in the directory, it should download the correct versions n such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants