Fixed bug that prevented processing of non-ascii symbols #918
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context.Request.Path.ToString() was leaving url encoded symbols as is. It means when further code tried to check if file exists on disc, result was always false in case of non-latin filenames.
…g-of-non-ascii-symbols Fixed bug that prevented processing of non-ascii urls
|
|
|
Thanks a ton for running this down! What's a good filename I can use to test locally just to verify the fix for you? |
Just use any cyrillic word, for example Тест, which means Test. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context.Request.Path.ToString() was leaving url encoded symbols as is. It means when further code tried to check if file exists on disc, result was always false in case of non-latin filenames.
I am not sure if any additional code is neccessary here. For some reason, I can't open and run Statiq solution on my PC properly.