Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hook into password rules #422

Closed
edalzell opened this issue Jan 2, 2021 · 5 comments · Fixed by statamic/cms#3823
Closed

Ability to hook into password rules #422

edalzell opened this issue Jan 2, 2021 · 5 comments · Fixed by statamic/cms#3823

Comments

@edalzell
Copy link

edalzell commented Jan 2, 2021

Recently saw this cool package: https://github.com/valorin/pwned-validator/.

Would be great if there was a way to add rules to the password validation, so folks could add this, if they wanted. Or other rules (complex password requirements, etc).

@rrelmy
Copy link

rrelmy commented May 10, 2021

This would be really helpful for projects with minimal password requirements

@duncanmcclean
Copy link
Member

duncanmcclean commented May 10, 2021

Not sure this really fixes the problem but maybe Statamic could hook into new functionality from this PR. laravel/framework#36960. Only issue is that it's Laravel 8 onwards 😂

@rrelmy
Copy link

rrelmy commented May 10, 2021

I need at least some basic requirements on passwords because of a goverment project and am be willing to create a PR with a basic implementation for it.

My idea would be to make the current password validations (required|confirmed) configurable inside config/statamic/users.php configuration.

Would such a PR be welcome?

@jasonvarga
Copy link
Member

Yup.

@rrelmy
Copy link

rrelmy commented May 17, 2021

I made a pull-request with a minimal proposal how to add additional validation rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants