Skip to content

Add asset option to Link fieldtype #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2022
Merged

Add asset option to Link fieldtype #4647

merged 8 commits into from
Mar 10, 2022

Conversation

jacksleight
Copy link
Contributor

@jacksleight jacksleight commented Nov 3, 2021

This is an implementation of this idea statamic/ideas#493

Includes:

  • Updated Assets/AssetReferenceUpdater to handle link fields (this is the bit I was most unsure of, the implementation works but there could be a better way to do it)
  • Updated Routing/ResolveRedirect to handle asset URLs
  • An AssetReferenceUpdater test

@jackmcdade jackmcdade requested a review from jasonvarga November 3, 2021 17:29
@jackmcdade
Copy link
Member

Wow, thank you for this PR! We'll have a look and pop the hood! ❤️

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jackmcdade
Copy link
Member

I can confirm it works great – will leave the code review to @jasonvarga tho 👌

@jackmcdade jackmcdade self-requested a review December 22, 2021 19:02
Copy link
Member

@jackmcdade jackmcdade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@jasonvarga jasonvarga merged commit 8045ebc into statamic:3.2 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants