Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field config toggles with default true can't be set to false #10040

Closed
jacksleight opened this issue May 10, 2024 · 0 comments · Fixed by #10059
Closed

Field config toggles with default true can't be set to false #10040

jacksleight opened this issue May 10, 2024 · 0 comments · Fixed by #10059
Labels
blueprints & fieldsets

Comments

@jacksleight
Copy link
Contributor

Bug description

It's not possible to set a field config toggle value that has a default of true to false through the blueprint editor. When you save the key is removed from the YAML. I'm guessing this is caused by #9685.

How to reproduce

  1. Open a blueprint
  2. Add a field
  3. Switch off one of the enabled toggles eg. Duplicate
  4. Apply, Save, Reload
  5. Open the field config, the toggle is back on

Logs

No response

Environment

Statamic
Addons: 5
Sites: 1
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.0.1 PRO

Installation

Fresh statamic/statamic site via CLI

Additional details

No response
@jasonvarga jasonvarga mentioned this issue May 13, 2024
Merged
3 tasks
jasonvarga added a commit that referenced this issue May 13, 2024
@jasonvarga
"duplicate" shouldn't have been moved to this condition ...
b478791 
before the other PR, the logic was to remove "duplicate" if it was true. this is now saying to always remove it, which is incorrect. partly solves #10040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blueprints & fieldsets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.x] Prevent certain blueprint config keys getting stripped out statamic/cms
2 participants
@jacksleight @duncanmcclean