Skip to content

Add CORS middleware and support for OPTIONS requests #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 12, 2022

Conversation

Goldziher
Copy link
Contributor

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

This PR closes #754 and #669, it additionally closes the Starlette Meta tracking (#634) issue as complete.

Sorry, something went wrong.

@Goldziher Goldziher requested review from seladb, jonadaly and a team November 11, 2022 17:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* remove python 3.7 support

* update imports of literal

* update cache key

* updated examples tests
@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2022

This pull request fixes 1 alert when merging f8120b0 into 43b62da - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Goldziher and others added 2 commits November 12, 2022 07:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Konstantin Mikhailov <jtraub@users.noreply.github.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Konstantin Mikhailov <jtraub@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2022

This pull request fixes 1 alert when merging 0a12a09 into 43b62da - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2022

This pull request fixes 1 alert when merging 27169cb into 43b62da - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Goldziher and others added 2 commits November 12, 2022 09:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Peter Schutt <peter@topsport.com.au>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Peter Schutt <peter@topsport.com.au>
@Goldziher Goldziher merged commit 42003f9 into main Nov 12, 2022
@Goldziher Goldziher deleted the 754-cors-and-options branch November 12, 2022 08:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2022

This pull request fixes 1 alert when merging f50a72e into 43b62da - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add Support for OPTIONS method
3 participants