Cleanup builtin middlewares

[jtraub]

PR Checklist

• Have you followed the guidelines in CONTRIBUTING.md?
• Have you got 100% test coverage on new code?
• Have you updated the prose documentation?
• Have you updated the reference documentation?

Here I add exclude_opt_key to all middlewares (logging, rate_limiting) and do some code cleanup by reusing code either from utils or AbstractMiddleware where applicable, fixing typos in docstrings and unifying parameter typing.

I need to write a few tests (while we have tests for exclusion for AbstractMiddleware we need to make sure that params from config are properly wired to init args and we need at least one test per middleware for that) and update docs that all builtin middleware support exclusion via pattern list or opt key

Also, there is another question that needs to be discussed I think.

At the moment AbstractAuthenticationMiddleware uses exclude_from_auth_key param with the default value of exclude_from_auth. CSRFMiddleware uses exclude_from_csrf_key config property (default value is exclude_from_csrf) and session middleware has exclude_opt_key config prop with the default value of skip_session. All other middleware use exclude_opt_key param with None as its default value.

While having default value is ok for a middleware that users want to disable often (I think turning off CSRF or Auth happens more frequently than disabling logging on some handlers) but I think it would be great to be consistent with param name. So what do you think about deprecation and switching in the future to the same param name?

[Goldziher]

gr8

[Goldziher]

Love it