Enhancement: Adds SecretStr, Path, and Enum to built in serializer

[cofin]

In the interest of not leaving this open too long, I'm submitting with the initial ones and a framework that we can add additional ones to relatively quickly. Let me know if this look ok

Resolves #458

[lgtm-com]

This pull request introduces 1 alert when merging 6ceabd3 into 9452390 - view on LGTM.com

new alerts:

• 1 for Unused import

[dannya]

@cofin is this ordering correct?
wouldn't you want the SecretStr to take priority over all other types?

[Goldziher]

why?

[dannya]

Is it possible that someone passes in an object that extends both BaseModel and SecretStr?

…

On Mon, 12 Sep 2022, at 7:15 PM, Goldziher wrote: ***@***.**** commented on this pull request. In starlite/response.py <#472 (comment)>: > @@ -74,6 +75,10 @@ def serializer(value: Any) -> Dict[str, Any]: """ if isinstance(value, BaseModel): return value.dict() + if isinstance(value, SecretStr): why? — Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADALP6HZC3MW7O3VUORW5LV55XL5ANCNFSM6AAAAAAQJNLS2U>. You are receiving this because you commented.Message ID: ***@***.***>

[Goldziher]

Is it possible that someone passes in an object that extends both BaseModel and SecretStr?

On Mon, 12 Sep 2022, at 7:15 PM, Goldziher wrote:

@.**** commented on this pull request.

In starlite/response.py #472 (comment):

@@ -74,6 +75,10 @@ def serializer(value: Any) -> Dict[str, Any]:
"""
if isinstance(value, BaseModel):
return value.dict()

•    if isinstance(value, SecretStr):
  

why?

—
Reply to this email directly, view it on GitHub #472 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AADALP6HZC3MW7O3VUORW5LV55XL5ANCNFSM6AAAAAAQJNLS2U.
You are receiving this because you commented.Message ID: @.***>

I can't see how it is tbh.