Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support total ordering #55

Closed
joseluis opened this issue Jul 10, 2022 · 1 comment · Fixed by #57
Closed

support total ordering #55

joseluis opened this issue Jul 10, 2022 · 1 comment · Fixed by #57
Labels
enhancement help wanted

Comments

@joseluis
Copy link
Contributor

Rust stabilized in 1.62 the total_cmp method that follows the totalOrder predicate from the IEEE754 spec (v2008, 5.10).

The same method could be added easily if it calculated the total order after converting to f32. There could also be total_cmp & total_cmp_const variants.

If bumping the MSRV to 1.62 is a problem, it'd be also very easy to reimplement it from scratch.
@starkat99
Copy link
Owner

Due to earlier incidents involving bumping MSRV, any changes in MSRV in this crate will require a major version bump, so I'd usually like to avoid unless there's a very clear need. I'd be happy to accept a PR adding a total ordering implementation, I just don't have the time to do it myself right now.

@joseluis joseluis mentioned this issue Jul 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add total_cmp method joseluis/half-rs
2 participants
@joseluis @starkat99