Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0008: Flaw in hyper allows request smuggling by sending a body in GET requests #79

Open
github-actions bot opened this issue Apr 1, 2020 · 3 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@github-actions
Copy link

github-actions bot commented Apr 1, 2020

Flaw in hyper allows request smuggling by sending a body in GET requests

Details
Package hyper
Version 0.10.16
URL hyperium/hyper#1925
Date 2020-03-19
Patched versions >= 0.12.34

Vulnerable versions of hyper allow GET requests to have bodies, even if there is
no Transfer-Encoding or Content-Length header. As per the HTTP 1.1
specification, such requests do not have bodies, so the body will be interpreted
as a separate HTTP request.

This allows an attacker who can control the body and method of an HTTP request
made by hyper to inject a request with headers that would not otherwise be
allowed, as demonstrated by sending a malformed HTTP request from a Substrate
runtime. This allows bypassing CORS restrictions. In combination with other
vulnerabilities, such as an exploitable web server listening on loopback, it may
allow remote code execution.

The flaw was corrected in hyper version 0.12.34.

See advisory page for additional details.

@jolestar jolestar added this to the proxima milestone Apr 25, 2020
@nanne007
Copy link
Member

不太好改。这个依赖是 jsonrpc 依赖 websocket,websocket 再依赖的 hyper。
https://github.com/websockets-rs/rust-websocket/blob/e9a3c9c93003ac733d04fafe83b3d8f882c31565/Cargo.toml#L20

@jolestar jolestar removed this from the proxima milestone Jul 13, 2020
@jolestar jolestar added this to the starcoin-1.0 milestone Dec 3, 2020
@jolestar jolestar added the dependencies Pull requests that update a dependency file label Dec 3, 2020
@jolestar jolestar assigned sanlee42 and unassigned nanne007 Jan 13, 2021
@jolestar
Copy link
Member

check this after #1822

@jolestar
Copy link
Member

json rpc 升级后,这个问题依然还存在

@jolestar jolestar removed this from the starcoin-1.0 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants