Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rubocop to 1.31 #430

Closed
LandonSchropp opened this issue Jun 28, 2022 · 7 comments
Closed

Bump Rubocop to 1.31 #430

LandonSchropp opened this issue Jun 28, 2022 · 7 comments
Labels
enhancement ✨ New feature or request

Comments

@LandonSchropp
Copy link

LandonSchropp commented Jun 28, 2022

Rubocop has added the new --server flag in 1.31. I'd love to be able to use it. 🙂

@searls
Copy link
Contributor

searls commented Jun 29, 2022

This is the relevant PR: rubocop/rubocop#10706

I don't know what an implementation like this would look like for Standard (and haven't used the rubocop-daemon so may not be appreciating what I might be missing). Open to more discussion on the benefits and what an implementation plan might look like

@searls searls closed this as completed Jun 29, 2022
@searls searls reopened this Jun 29, 2022
@searls searls added the enhancement ✨ New feature or request label Jun 29, 2022
@LandonSchropp
Copy link
Author

Thank you for tackling this!

I should have clarified in my original post that my team is using the standard.rb Rubocop configuration directly rather than the CLI.

In terms of integrating with the standard CLI, I believe there are six new Rubocop flags:

  • --[no-]server
  • --restart-server
  • --start-server
  • --stop-server
  • --server-status

Maybe it's as simple as passing those flags directly to Rubocop under the hood?

@LandonSchropp
Copy link
Author

For now, if you could bump the dependency in standard that would solve my problem. If I try to update to 1.31 in my repo, I get the following error:

Bundler could not find compatible versions for gem "rubocop":
  In Gemfile:
    rubocop (~> 1.31)

    standard (~> 1.10) was resolved to 1.12.1, which depends on
      rubocop (= 1.29.1)

@kylefox
Copy link

kylefox commented Jul 17, 2022

@searls Could you please have another look at updating the rubocop dependency? 😁

I'm running into some issues because Standard is locked to rubocop (= 1.29.1):

Bundler could not find compatible versions for gem "rubocop":
  In snapshot (Gemfile.lock):
    rubocop (>= 1.29.1)

  In Gemfile:
    rubocop-rspec (= 2.12.1) was resolved to 2.12.1, which depends on
      rubocop (~> 1.31)

    standard was resolved to 1.12.1, which depends on
      rubocop (= 1.29.1)

@searls
Copy link
Contributor

searls commented Jul 17, 2022

I believe @camilopayan is working on a dependency update release soon

@camilopayan
Copy link
Contributor

Yep, v1.13.0 just out! I appreciate the patience.

@kylefox
Copy link

kylefox commented Jul 21, 2022

Thanks @camilopayan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants