Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceAroundMethodCallOperator makes standard much slower on large files #188

Closed
JelteF opened this issue Jul 20, 2020 · 2 comments
Closed

Comments

@JelteF
Copy link

JelteF commented Jul 20, 2020

The following lines make standardrb run for 6 seconds instead of 3 seconds on a specific file in my codebase: https://github.com/testdouble/standard/blob/baa79c38ad24f987fd1460cf1a86fba2f44c3ede/config/base.yml#L499-L500

The root-cause for this is that in Rubocop versions below 0.88.0 it is an O(n^2) lint (rubocop/rubocop#8348, rubocop/rubocop#8021)

To fix this, either the rule should be disabled or the rubocop version should be updated to 0.88.0.

@searls
Copy link
Contributor

searls commented Jul 20, 2020

Thank you for the incredibly detailed report! I'm overdue to upgrade our pegged rubocop version so I'll get on that shortly

@searls
Copy link
Contributor

searls commented Aug 23, 2020

As of yesterday's release of standard@0.5.0, rubocop is bumped to 0.89.1

@searls searls closed this as completed Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants